-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with pip install proposal
for Windows / VS
#376
Comments
One solution would be to use Ninja as the build system, which is supported on all platforms and available from PyPI, so it can be put into the (scikit-build-core also uses ninja) Ninja parallizes the build by default to all available cores |
A new issue that seemed to have emerged on Windows:
The verbose output from
My workaround so far was to copy the I don't know how to tell setup.py to add this file -- and I also believed that this has worked earlier, so something about Windows must have changed...? |
I would suggest to try switching to scikit-build-core and not apply further hacks to the current cmake code in setup.py |
There is a report of installation issues when trying to install PROPOSAL with
pip install proposal
on Windows machines.Firstly, CMake fails with the error
Might be related to conan-io/conan#12458
This can be fixed by explicitly setting
DCMAKE_POLICY_DEFAULT_CMP0091
.However, then there is another problem with CMake:
Apparently, there is a problem with the way
-j2
is passed fromsetup.py
to CMake. This can temporarily be fixed by disabling-j
.For now, I have created the branch
disable_multicore_build
which fixes these two issues. Until this if fixed on the master, installation is possible withThe text was updated successfully, but these errors were encountered: