Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging accounts #6

Closed
michielbdejong opened this issue Nov 29, 2024 · 4 comments
Closed

Merging accounts #6

michielbdejong opened this issue Nov 29, 2024 · 4 comments

Comments

@michielbdejong
Copy link
Contributor

Scenario:

  • a user logs in with Slack -> session id 1
  • they log out
  • now they log in with Solid -> session id 2
  • then they log in with Slack again -> update all occurrences of session id 1 to become session id 2

Does this make sense?

@michielbdejong
Copy link
Contributor Author

OK, now another scenario:

  • log into Slack on device A -> session id 1
  • log into Solid on device B -> session id 2
  • log into Slack on device B -> update all occurrences of session id 1 to become session id 2
  • the session on device A is broken

To deal with this, the identities table should link between identities and accounts,
and the sessions table should link between sessions and accounts, and then we merge the accounts instead of the sessions.

@michielbdejong michielbdejong changed the title Merging sessions Merging accounts Nov 29, 2024
@michielbdejong
Copy link
Contributor Author

Hm, actually having the indirection through accounts is one option.
Another option is to keep accounts and sessions equivalent, and when sessions merge, update all current session ids (through a websocket push? or through a special database table that looks up old session id -> new session id?)

@michielbdejong
Copy link
Contributor Author

In any case it's something we can leave for later, not necessarily in scope for #3.

@michielbdejong
Copy link
Contributor Author

Merging this issue back into tubsproject/reflector#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant