Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: 48 block randomization algorithm poc #76

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JagGlo
Copy link
Contributor

@JagGlo JagGlo commented Feb 29, 2024

No description provided.

@JagGlo JagGlo marked this pull request as draft February 29, 2024 11:27
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ed1e66e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage        ?   96.42%           
=======================================
  Files           ?        9           
  Lines           ?      560           
  Branches        ?        0           
=======================================
  Hits            ?      540           
  Misses          ?       20           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from devel to main March 8, 2024 14:31
Copy link
Contributor

@kamilsi kamilsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's brek it down to tasks

block_size = c(3, 6, 9),
covariates = list(
sex = list(
weight = NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no reason to keep it, then let's drop "weight"

Copy link

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just passing by because @kamilsi presented unbiased to our openstatsware team today - but I love that you are using this Rmd with the design/PoC for your package development! We also do this a lot in our packages but so far I have not seen this actively in other places too much. Great work!

@JagGlo JagGlo linked an issue Dec 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block randomization algorithm as function
3 participants