fix: add manual_json validation and playwright-test #269
Conversation
RohittCodes
changed the title
|
i forgot to claim the bounty for #265. and the fix for it temporarily solved the issue. i.e., whenever a new snippet was created it still showed the "Unsaved changes" text. This PR solves the issues with |
| const newSnippet = snippetSchema.parse({ | ||
| ...snippet, | ||
| manual_edits_json: JSON.stringify(manualEditsJsonTemplate, null, 2), |
There was a problem hiding this comment.
can we keep this object as null by default
There was a problem hiding this comment.
if there is an issue with the default value, that should be handled on the frontend the first time it's selected
RohittCodes
changed the title
|
@seveibar all the failing tests are passing in my local setup again. Not sure what's causing the checks fail here. 🤷♂️ |
|
@RohittCodes can you make sure youve got the latest deps by running "bun i" locally then rerunning tests. Is it a timeout issue on ci? |
|
yeah all the deps are up to date, and i don't think there is any timeout issue for |
|
Hmm maybe configure for longer timeout in the config/workflow? |
This reverts commit eb9cada.
|
@seveibar nah this too doesn't work. the bun tests have passed but there's some issue with the playwright test for preview-page. |
refactored: manual_edit_json template ingestion into db.
included playwright tests
fixes: #261
/claim #261
cc: @seveibar