Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iframe embedding of snippets #171

Closed
seveibar opened this issue Nov 6, 2024 · 6 comments
Closed

Allow iframe embedding of snippets #171

seveibar opened this issue Nov 6, 2024 · 6 comments

Comments

@seveibar
Copy link
Contributor

seveibar commented Nov 6, 2024

Will require serving PreviewContent from a URL

the route could be something like /preview?snippet_id=...

No other page context except PreviewContent, automatically scaled to iframe size

@seveibar
Copy link
Contributor Author

seveibar commented Nov 8, 2024

/bounty $40

Copy link

algora-pbc bot commented Nov 8, 2024

## 💎 $40 bounty • tscircuit

### Steps to solve:
1. Start working: Comment /attempt #171 with your implementation plan
2. Submit work: Create a pull request including /claim #171 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/snippets!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @mrudulpatil18 #179

@RohittCodes
Copy link
Contributor

@seveibar if I understand correctly, this should be a separate page for previews only. like there is a copy url button for sharing editor, which routes to /editor?snippet_id=...

Image

If so, can I provide a dropdown here, instead of copy url, with two separate buttons for share preview and share code/editor?

@seveibar
Copy link
Contributor Author

seveibar commented Nov 8, 2024

@RohittCodes from the "view snippets" page, users can get the iframe url. I'd prefer not to change that button on the editor page for now, I have some other plans for it

Copy link

algora-pbc bot commented Nov 9, 2024

💡 @mrudulpatil18 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Nov 16, 2024

🎉🎈 @mrudulpatil18 has been awarded $40! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants