You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, it stops working as soon as I change the local path to either:
.. or ../ - to simply indicate the parent directory
~/configs/trunk or $HOME/configs/trunk - to point to the home directory via tilde expansion or env variable
Is this something that could/should be supported?
It works with ../shared or absolute paths like: /Users/skoti/configs/trunk so might be not worth adding.
If not then it should be fixed to return a proper error.
As .. or ../ makes trunk to hang for infinity ♾️ .
And the tilde expansion returns:
.trunk/trunk.yaml:9:7
9:7 high [skoti] '~/configs/trunk' does not exist trunk/config-error
Unable to run check due to invalid config
Which is not true because the file exists, so I would expect something like an unrecognized path error or if we can be specific unsupported path expansion.
Interestingly, if I put a symlink ../shared/plugin.yaml to point to ~/configs/trunk/plugin.yaml via tilde expansion then it works. So looks like only the configured path is significant.
The text was updated successfully, but these errors were encountered:
Hi! This is more or less expected behavior for the moment, but I agree the UX isn't great. Some notes:
We don't support ../ since we recursively load plugin.yaml, files, which could lead to some unexpected results if it's also based on your current repo. Regardless, we should include a better error message if you choose a parent/ancestor of your current dir. ../shared is an officially supported use case, as you saw
We don't do any template resolution for that path for HOME or ~, but we certainly could! I've filed this feature request to track it, which you can upvote
Let me know if you have any other questions! We will work on improving the UX here
I have a config like this:
the
../shared
containsplugin.yaml
and it works.However, it stops working as soon as I change the local path to either:
..
or../
- to simply indicate the parent directory~/configs/trunk
or$HOME/configs/trunk
- to point to the home directory via tilde expansion or env variableIs this something that could/should be supported?
It works with
../shared
or absolute paths like:/Users/skoti/configs/trunk
so might be not worth adding.If not then it should be fixed to return a proper error.
As
..
or../
makestrunk
to hang for infinity ♾️ .And the tilde expansion returns:
.trunk/trunk.yaml:9:7 9:7 high [skoti] '~/configs/trunk' does not exist trunk/config-error Unable to run check due to invalid config
Which is not true because the file exists, so I would expect something like an unrecognized path error or if we can be specific unsupported path expansion.
Interestingly, if I put a symlink
../shared/plugin.yaml
to point to~/configs/trunk/plugin.yaml
via tilde expansion then it works. So looks like only the configured path is significant.The text was updated successfully, but these errors were encountered: