Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132636 / 25.04 / Upgrade to Angular 19 #11103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

NAS-132636 / 25.04 / Upgrade to Angular 19 #11103

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae7c96
NAS-132636: Upgrade to Angular 19
Nov 26, 2024
0498940
NAS-132636: Fix build command
Nov 26, 2024
609d3a1
NAS-132636: Fix output prefixes
Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"scripts": {
"prebuild": "yarn icons",
"prestart": "yarn icons",
"build": "yarn run clean:dist && node ./setup-production-env.js && node --max_old_space_size=8192 node_modules/@angular/cli/bin/ng build",
"build": "yarn run clean:dist && node ./setup-production-env.js && export NODE_OPTIONS=\"--max-old-space-size=8192\" && node node_modules/@angular/cli/bin/ng build",
"build:prod": "node ./setup-production-env.js && node scripts/setup_prod.js && yarn run build --configuration production",
"build:prod:aot": "node ./setup-production-env.js && yarn run build:prod --base-href /ui/",
"check-env": "cd $(git rev-parse --show-toplevel) && yarn run ui check-env",
Expand All @@ -24,8 +24,8 @@
"ng": "ng",
"prepare": "husky",
"reinstall": "rimraf yarn.lock; rimraf node_modules; yarn cache clean -f; yarn install",
"start": "yarn run check-env && node --max_old_space_size=8192 ./node_modules/@angular/cli/bin/ng serve --proxy-config proxy.config.json",
"start:prod": "node --max_old_space_size=8192 ./node_modules/@angular/cli/bin/ng serve --configuration production",
"start": "yarn run check-env && export NODE_OPTIONS=\"--max-old-space-size=8192\" && node ./node_modules/@angular/cli/bin/ng serve --proxy-config proxy.config.json",
"start:prod": "export NODE_OPTIONS=\"--max-old-space-size=8192\" && node ./node_modules/@angular/cli/bin/ng serve --configuration production",
"strict-null-checks": "node_modules/typescript/bin/tsc --project tsconfig.strictNullChecks.json",
"test": "jest",
"test:changed": "node scripts/test_changed.js",
Expand All @@ -47,20 +47,20 @@
},
"private": true,
"dependencies": {
"@angular-devkit/core": "^18.2.4",
"@angular/animations": "^18.2.4",
"@angular/build": "^18.2.4",
"@angular/cdk": "^18.2.4",
"@angular/cli": "^18.2.4",
"@angular/common": "^18.2.4",
"@angular/compiler": "^18.2.4",
"@angular/compiler-cli": "^18.2.4",
"@angular/core": "^18.2.4",
"@angular/forms": "^18.2.4",
"@angular/material": "^18.2.4",
"@angular/platform-browser": "^18.2.4",
"@angular/platform-browser-dynamic": "^18.2.4",
"@angular/router": "^18.2.4",
"@angular-devkit/core": "^19.0.2",
"@angular/animations": "^19.0.0",
"@angular/build": "^19.0.2",
"@angular/cdk": "^19.0.0",
"@angular/cli": "^19.0.2",
"@angular/common": "^19.0.0",
"@angular/compiler": "^19.0.0",
"@angular/compiler-cli": "^19.0.0",
"@angular/core": "^19.0.0",
"@angular/forms": "^19.0.0",
"@angular/material": "^19.0.0",
"@angular/platform-browser": "^19.0.0",
"@angular/platform-browser-dynamic": "^19.0.0",
"@angular/router": "^19.0.0",
"@biesbjerg/ngx-translate-extract-marker": "~1.0.0",
"@bugsplat/angular-tree-component": "~18.0.0",
"@codemirror/autocomplete": "~6.18.1",
Expand All @@ -86,13 +86,13 @@
"@ngneat/reactive-forms": "~5.0.2",
"@ngneat/spectator": "~19.0.0",
"@ngneat/until-destroy": "~10.0.0",
"@ngrx/component-store": "~18.0.2",
"@ngrx/effects": "~18.0.2",
"@ngrx/entity": "~18.0.2",
"@ngrx/operators": "^18.0.0",
"@ngrx/router-store": "~18.0.2",
"@ngrx/store": "~18.0.2",
"@ngrx/store-devtools": "~18.0.2",
"@ngrx/component-store": "~18.1.1",
"@ngrx/effects": "~18.1.1",
"@ngrx/entity": "~18.1.1",
"@ngrx/operators": "^18.1.1",
"@ngrx/router-store": "~18.1.1",
"@ngrx/store": "~18.1.1",
"@ngrx/store-devtools": "~18.1.1",
"@ngx-translate/core": "~15.0.0",
"@ngx-translate/http-loader": "~8.0.0",
"@popperjs/core": "^2.9.3",
Expand All @@ -119,7 +119,7 @@
"@xterm/addon-fit": "~0.10.0",
"@xterm/xterm": "~5.5.0",
"angular-dual-listbox": "~7.0.0",
"angular-eslint": "~18.4.0",
"angular-eslint": "~18.4.2",
"angular-resize-event": "^3.2.0",
"angular2-uuid": "~1.1.1",
"chart.js": "~4.4.4",
Expand Down Expand Up @@ -184,7 +184,7 @@
"ng2-fittext": "~2.0.0",
"ngx-drag-drop": "~18.0.2",
"ngx-img-fallback": "^3.0.0",
"ngx-markdown": "~18.0.0",
"ngx-markdown": "~19.0.0",
"ngx-popperjs": "^16.0.1",
"ngx-skeleton-loader": "~5.0.0",
"ngx-translate-messageformat-compiler": "~7.0.0",
Expand All @@ -203,7 +203,7 @@
"typescript-eslint": "~8.11.0",
"utility-types": "~3.11.0",
"vinyl": "~3.0.0",
"zone.js": "~0.14.10"
"zone.js": "~0.15.0"
},
"lint-staged": {
"*.{ts,html}": [
Expand Down
9 changes: 0 additions & 9 deletions src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,6 @@ export class AppComponent implements OnInit {
}
}
});

this.router.errorHandler = (err: Error) => {
const chunkFailedMessage = /Loading chunk \d+ failed/;

if (chunkFailedMessage.test(err.message)) {
this.window.location.reload();
}
console.error(err);
};
}

ngOnInit(): void {
Expand Down
2 changes: 0 additions & 2 deletions src/app/pages/sharing/iscsi/fibre-channel-ports/fibre-channel-ports.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { AsyncPipe } from '@angular/common';
import { ChangeDetectionStrategy, Component } from '@angular/core';
import { MatCard, MatCardContent } from '@angular/material/card';
import { MatToolbarRow } from '@angular/material/toolbar';
Expand All @@ -14,7 +13,6 @@ import { fibreChannelPortsElements } from 'app/pages/sharing/iscsi/fibre-channel
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: true,
imports: [
AsyncPipe,
FakeProgressBarComponent,
MatCard,
MatToolbarRow,
Expand Down
2 changes: 0 additions & 2 deletions .../pages/sharing/iscsi/global-target-configuration/global-target-configuration.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
} from '@angular/forms';
import { MatButton } from '@angular/material/button';
import { MatCard, MatCardContent } from '@angular/material/card';
import { MatProgressBar } from '@angular/material/progress-bar';
import { UntilDestroy, untilDestroyed } from '@ngneat/until-destroy';
import { Store } from '@ngrx/store';
import { TranslateModule, TranslateService } from '@ngx-translate/core';
Expand Down Expand Up @@ -42,7 +41,6 @@ import { checkIfServiceIsEnabled } from 'app/store/services/services.actions';
imports: [
MatCard,
MatCardContent,
MatProgressBar,
ReactiveFormsModule,
IxFieldsetComponent,
IxInputComponent,
Expand Down
2 changes: 0 additions & 2 deletions ...tances/instance-details/instance-disks/instance-disk-form/instance-disk-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { FormActionsComponent } from 'app/modules/forms/ix-forms/components/form
import { IxExplorerComponent } from 'app/modules/forms/ix-forms/components/ix-explorer/ix-explorer.component';
import { IxFieldsetComponent } from 'app/modules/forms/ix-forms/components/ix-fieldset/ix-fieldset.component';
import { IxInputComponent } from 'app/modules/forms/ix-forms/components/ix-input/ix-input.component';
import { IxListItemComponent } from 'app/modules/forms/ix-forms/components/ix-list/ix-list-item/ix-list-item.component';
import { FormErrorHandlerService } from 'app/modules/forms/ix-forms/services/form-error-handler.service';
import { ChainedRef } from 'app/modules/slide-ins/chained-component-ref';
import { ModalHeader2Component } from 'app/modules/slide-ins/components/modal-header2/modal-header2.component';
Expand All @@ -36,7 +35,6 @@ interface FormOptions {
imports: [
IxExplorerComponent,
IxInputComponent,
IxListItemComponent,
ReactiveFormsModule,
TranslateModule,
MatCard,
Expand Down
3 changes: 1 addition & 2 deletions ...tion/components/all-instances/instance-details/instance-tools/instance-tools.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
ChangeDetectionStrategy, Component, computed, input,
} from '@angular/core';
import { MatAnchor, MatButton } from '@angular/material/button';
import { MatAnchor } from '@angular/material/button';
import {
MatCard, MatCardContent, MatCardHeader, MatCardTitle,
} from '@angular/material/card';
Expand All @@ -25,7 +25,6 @@ import { TestDirective } from 'app/modules/test-id/test.directive';
MatCard,
MatCardContent,
TranslateModule,
MatButton,
MatAnchor,
TestDirective,
IxIconComponent,
Expand Down
Loading
Loading