Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132644 / 25.04 / Fix master #11097

Merged
merged 1 commit into from
Nov 25, 2024
Merged

NAS-132644 / 25.04 / Fix master #11097

merged 1 commit into from
Nov 25, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 25, 2024

Testing:

No review necessary, will merge once tests run.

@undsoft undsoft requested a review from a team as a code owner November 25, 2024 12:18
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team November 25, 2024 12:18
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132644: Fix master NAS-132644 / 25.04 / Fix master Nov 25, 2024
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I as well noticed and fixed that in my newest PR 😄

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.34%. Comparing base (2fc1361) to head (5c05aa7).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11097       +/-   ##
===========================================
+ Coverage   58.76%   82.34%   +23.57%     
===========================================
  Files        1643     1643               
  Lines       57484    57484               
  Branches     5930     5930               
===========================================
+ Hits        33783    47336    +13553     
+ Misses      23701    10148    -13553     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@undsoft undsoft merged commit 7ad0021 into master Nov 25, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132644-2 branch November 25, 2024 12:44
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants