From d63f4f261178b589672a30c92d78f2d34e8fa244 Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:16:15 +0530 Subject: [PATCH 1/8] update values of flyte helm chart --- charts/tfy-workflow-propeller/Chart.yaml | 2 +- charts/tfy-workflow-propeller/values.yaml | 28 ++++++++++++++++++++++- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/charts/tfy-workflow-propeller/Chart.yaml b/charts/tfy-workflow-propeller/Chart.yaml index 56c77aae..44439032 100644 --- a/charts/tfy-workflow-propeller/Chart.yaml +++ b/charts/tfy-workflow-propeller/Chart.yaml @@ -4,7 +4,7 @@ type: application description: "Workflow propeller" maintainers: - name: truefoundry -version: 0.0.2 +version: 0.0.3 dependencies: - name: flyte-core version: v1.13.2 diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index c4fcee55..527fb2c7 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -33,10 +33,18 @@ flyte-core: enable-multicontainer: true webhook: ## @param flyte-core.webhook.enabled to enable the webhook - enabled: true + enabled: false configmap: + k8s: + plugins: + k8s: + ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars to set the default env vars + default-env-vars: + - TFY_INTERNAL_SIGNED_URL_SERVER_HOST: http://tfy-signed-url-server.tfy-workflow-propeller.svc.cluster.local:3001 core: propeller: + ## @param flyte-core.configmap.core.propeller.max-ttl-hours to set the max ttl hours + max-ttl-hours: 1 ## @param flyte-core.configmap.core.propeller.metadata-prefix to set the storage uri path to set store the metadata, its values should be bucketName/metadata metadata-prefix: /workflows/metadata ## @param flyte-core.configmap.core.propeller.rawoutput-prefix to set the storage uri path to set store the raw output, its values should be bucketName/raw_data @@ -81,6 +89,24 @@ flyte-core: flytepropeller: ## @param flyte-core.flytepropeller.enabled to enable the flytepropeller enabled: true + ## @param flyte-core.flytepropeller.resources to set the resources + resources: + ## @param flyte-core.flytepropeller.resources.limits to set the resource limits + limits: + ## @param flyte-core.flytepropeller.resources.limits.cpu to set the cpu limit + cpu: 1 + ## @param flyte-core.flytepropeller.resources.limits.memory to set the memory limit + memory: 800Mi + ## @param flyte-core.flytepropeller.resources.limits.ephemeral-storage to set the ephemeral storage limit + ephemeral-storage: 2Gi + ## @param flyte-core.flytepropeller.resources.requests to set the resource requests + requests: + ## @param flyte-core.flytepropeller.resources.requests.cpu to set the cpu request + cpu: 0.5 + ## @param flyte-core.flytepropeller.resources.requests.memory to set the memory request + memory: 500Mi + ## @param flyte-core.flytepropeller.resources.requests.ephemeral-storage to set the ephemeral storage request + ephemeral-storage: 1Gi serviceAccount: ## @param flyte-core.flytepropeller.serviceAccount.create to configure whether to create the service account or not create: true From c8255878a8fefa10575147112d748b3fe8d8323a Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:23:17 +0530 Subject: [PATCH 2/8] nit set default workflot retries --- charts/tfy-workflow-propeller/values.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index 527fb2c7..4288e8b8 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -45,6 +45,8 @@ flyte-core: propeller: ## @param flyte-core.configmap.core.propeller.max-ttl-hours to set the max ttl hours max-ttl-hours: 1 + ## @param flyte-core.configmap.core.propeller.max-workflow-retries to set the max workflow retries + max-workflow-retries: 5 ## @param flyte-core.configmap.core.propeller.metadata-prefix to set the storage uri path to set store the metadata, its values should be bucketName/metadata metadata-prefix: /workflows/metadata ## @param flyte-core.configmap.core.propeller.rawoutput-prefix to set the storage uri path to set store the raw output, its values should be bucketName/raw_data From fee031d063e75bc34d20a9c2e0267bb6cfb804da Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:39:12 +0530 Subject: [PATCH 3/8] nit: remove unused field --- charts/tfy-workflow-propeller/values.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index 4288e8b8..67db02b9 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -29,8 +29,6 @@ flyte-core: region: ## @param flyte-core.storage.connection.auth-type to define the storage connection auth type auth-type: - ## @param flyte-core.storage.enable-multicontainer to enable the multicontainer - enable-multicontainer: true webhook: ## @param flyte-core.webhook.enabled to enable the webhook enabled: false From b757b20db23f0ae0d1006c9e354bc583b36da0a1 Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:40:39 +0530 Subject: [PATCH 4/8] nit update for readme --- charts/tfy-workflow-propeller/values.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index 67db02b9..9d312489 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -38,6 +38,7 @@ flyte-core: k8s: ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars to set the default env vars default-env-vars: + ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars.TFY_INTERNAL_SIGNED_URL_SERVER_HOST to set the signed url server host - TFY_INTERNAL_SIGNED_URL_SERVER_HOST: http://tfy-signed-url-server.tfy-workflow-propeller.svc.cluster.local:3001 core: propeller: From 55e36fe545ed98f1b433b1eb8546be820a89bcdb Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:42:49 +0530 Subject: [PATCH 5/8] nit --- charts/tfy-workflow-propeller/values.yaml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index 9d312489..3b2fe9dc 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -32,9 +32,13 @@ flyte-core: webhook: ## @param flyte-core.webhook.enabled to enable the webhook enabled: false + ## @section flyte-core.configmap configurations configmap: + ## @section flyte-core.configmap.k8s configurations k8s: + ## @section flyte-core.configmap.k8s.plugins configurations plugins: + ## @section flyte-core.configmap.k8s.plugins.k8s configurations k8s: ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars to set the default env vars default-env-vars: @@ -90,23 +94,14 @@ flyte-core: flytepropeller: ## @param flyte-core.flytepropeller.enabled to enable the flytepropeller enabled: true - ## @param flyte-core.flytepropeller.resources to set the resources resources: - ## @param flyte-core.flytepropeller.resources.limits to set the resource limits limits: - ## @param flyte-core.flytepropeller.resources.limits.cpu to set the cpu limit cpu: 1 - ## @param flyte-core.flytepropeller.resources.limits.memory to set the memory limit memory: 800Mi - ## @param flyte-core.flytepropeller.resources.limits.ephemeral-storage to set the ephemeral storage limit ephemeral-storage: 2Gi - ## @param flyte-core.flytepropeller.resources.requests to set the resource requests requests: - ## @param flyte-core.flytepropeller.resources.requests.cpu to set the cpu request cpu: 0.5 - ## @param flyte-core.flytepropeller.resources.requests.memory to set the memory request memory: 500Mi - ## @param flyte-core.flytepropeller.resources.requests.ephemeral-storage to set the ephemeral storage request ephemeral-storage: 1Gi serviceAccount: ## @param flyte-core.flytepropeller.serviceAccount.create to configure whether to create the service account or not From d46eb2d6d2e0bc1942bdeb585415e680c2e7988c Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:48:08 +0530 Subject: [PATCH 6/8] nit --- charts/tfy-workflow-propeller/values.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index 3b2fe9dc..f2021194 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -32,17 +32,12 @@ flyte-core: webhook: ## @param flyte-core.webhook.enabled to enable the webhook enabled: false - ## @section flyte-core.configmap configurations configmap: - ## @section flyte-core.configmap.k8s configurations k8s: - ## @section flyte-core.configmap.k8s.plugins configurations plugins: - ## @section flyte-core.configmap.k8s.plugins.k8s configurations k8s: ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars to set the default env vars default-env-vars: - ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars.TFY_INTERNAL_SIGNED_URL_SERVER_HOST to set the signed url server host - TFY_INTERNAL_SIGNED_URL_SERVER_HOST: http://tfy-signed-url-server.tfy-workflow-propeller.svc.cluster.local:3001 core: propeller: From 1c4ee248100fd1be9eeeffcf3b32e0b2ec1a1c74 Mon Sep 17 00:00:00 2001 From: Nikhil Popli Date: Fri, 29 Nov 2024 19:50:10 +0530 Subject: [PATCH 7/8] nit --- charts/tfy-workflow-propeller/values.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/charts/tfy-workflow-propeller/values.yaml b/charts/tfy-workflow-propeller/values.yaml index f2021194..116fb3db 100644 --- a/charts/tfy-workflow-propeller/values.yaml +++ b/charts/tfy-workflow-propeller/values.yaml @@ -36,8 +36,8 @@ flyte-core: k8s: plugins: k8s: - ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars to set the default env vars default-env-vars: + ## @param flyte-core.configmap.k8s.plugins.k8s.default-env-vars[0].TFY_INTERNAL_SIGNED_URL_SERVER_HOST to set the signed url server host - TFY_INTERNAL_SIGNED_URL_SERVER_HOST: http://tfy-signed-url-server.tfy-workflow-propeller.svc.cluster.local:3001 core: propeller: @@ -91,12 +91,18 @@ flyte-core: enabled: true resources: limits: + ## @param flyte-core.flytepropeller.resources.limits.cpu to set the cpu limit cpu: 1 + ## @param flyte-core.flytepropeller.resources.limits.memory to set the memory limit memory: 800Mi + ## @param flyte-core.flytepropeller.resources.limits.ephemeral-storage to set the ephemeral storage limit ephemeral-storage: 2Gi requests: + ## @param flyte-core.flytepropeller.resources.requests.cpu to set the cpu request cpu: 0.5 + ## @param flyte-core.flytepropeller.resources.requests.memory to set the memory request memory: 500Mi + ## @param flyte-core.flytepropeller.resources.requests.ephemeral-storage to set the ephemeral storage request ephemeral-storage: 1Gi serviceAccount: ## @param flyte-core.flytepropeller.serviceAccount.create to configure whether to create the service account or not From b88d2648dc19b4b12383015d9dc39d12978d8f51 Mon Sep 17 00:00:00 2001 From: nikp1172 Date: Fri, 29 Nov 2024 14:20:31 +0000 Subject: [PATCH 8/8] Update README.md with readme-generator-for-helm Signed-off-by: nikp1172 --- charts/tfy-workflow-propeller/README.md | 74 ++++++++++++++----------- 1 file changed, 41 insertions(+), 33 deletions(-) diff --git a/charts/tfy-workflow-propeller/README.md b/charts/tfy-workflow-propeller/README.md index 3398b45f..6a72c992 100644 --- a/charts/tfy-workflow-propeller/README.md +++ b/charts/tfy-workflow-propeller/README.md @@ -13,39 +13,47 @@ This Helm chart package, provided by TrueFoundry, contains configurations and re ### flyte-core configurations -| Name | Description | Value | -| --------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------- | ------------------------------------- | -| `flyte-core.common.ingress.enabled` | to enable the ingress | `false` | -| `flyte-core.secrets.adminOauthClientCredentials.enabled` | to enable Oauth client credentials | `true` | -| `flyte-core.storage.type` | to define the storage type | `` | -| `flyte-core.storage.limits.maxDownloadMBs` | to define the max download size | `2` | -| `flyte-core.storage.bucketName` | to define the storage bucket name | `` | -| `flyte-core.storage.connection.region` | to define the storage connection region | `` | -| `flyte-core.storage.connection.auth-type` | to define the storage connection auth type | `` | -| `flyte-core.storage.enable-multicontainer` | to enable the multicontainer | `true` | -| `flyte-core.webhook.enabled` | to enable the webhook | `true` | -| `flyte-core.configmap.core.propeller.metadata-prefix` | to set the storage uri path to set store the metadata, its values should be bucketName/metadata | `/workflows/metadata` | -| `flyte-core.configmap.core.propeller.rawoutput-prefix` | to set the storage uri path to set store the raw output, its values should be bucketName/raw_data | `/workflows/raw_data` | -| `flyte-core.configmap.core.propeller.publish-k8s-events` | to publish kube events | `true` | -| `flyte-core.configmap.admin.admin.Command` | to set the external command | `["echo",""]` | -| `flyte-core.configmap.admin.admin.AuthType` | to set the auth type | `ExternalCommand` | -| `flyte-core.configmap.admin.admin.endpoint` | to set the endpoint | `` | -| `flyte-core.configmap.admin.admin.insecure` | to set the insecure flag | `false` | -| `flyte-core.configmap.admin.admin.AuthorizationHeader` | to set the authorization header type | `authorization` | -| `flyte-core.configmap.admin.event.rate` | to set the rate | `500` | -| `flyte-core.configmap.admin.event.type` | to set the type | `admin` | -| `flyte-core.configmap.admin.event.capacity` | to set the capacity | `100` | -| `flyte-core.configmap.logger.level` | to set the log level | `5` | -| `flyte-core.configmap.logger.show-source` | to set the log format | `true` | -| `flyte-core.flyteadmin.enabled` | to enable the flyteadmin | `false` | -| `flyte-core.datacatalog.enabled` | to enable the datacatalog | `false` | -| `flyte-core.flyteconsole.enabled` | to enable the flyteconsole | `false` | -| `flyte-core.flytepropeller.enabled` | to enable the flytepropeller | `true` | -| `flyte-core.flytepropeller.serviceAccount.create` | to configure whether to create the service account or not | `true` | -| `flyte-core.flytepropeller.serviceAccount.annotations.eks.amazonaws.com/role-arn` | to set the role arn to access service account | `` | -| `flyte-core.workflow_scheduler.enabled` | to enable workflow scheduler | `false` | -| `flyte-core.workflow_notifications.enabled` | to enable the workflow notifications | `false` | -| `flyte-core.cluster_resource_manager.enabled` | to enable the cluster resource manager | `false` | +| Name | Description | Value | +| ---------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------- | +| `flyte-core.common.ingress.enabled` | to enable the ingress | `false` | +| `flyte-core.secrets.adminOauthClientCredentials.enabled` | to enable Oauth client credentials | `true` | +| `flyte-core.storage.type` | to define the storage type | `` | +| `flyte-core.storage.limits.maxDownloadMBs` | to define the max download size | `2` | +| `flyte-core.storage.bucketName` | to define the storage bucket name | `` | +| `flyte-core.storage.connection.region` | to define the storage connection region | `` | +| `flyte-core.storage.connection.auth-type` | to define the storage connection auth type | `` | +| `flyte-core.webhook.enabled` | to enable the webhook | `false` | +| `flyte-core.configmap.k8s.plugins.k8s.default-env-vars[0].TFY_INTERNAL_SIGNED_URL_SERVER_HOST` | to set the signed url server host | `http://tfy-signed-url-server.tfy-workflow-propeller.svc.cluster.local:3001` | +| `flyte-core.configmap.core.propeller.max-ttl-hours` | to set the max ttl hours | `1` | +| `flyte-core.configmap.core.propeller.max-workflow-retries` | to set the max workflow retries | `5` | +| `flyte-core.configmap.core.propeller.metadata-prefix` | to set the storage uri path to set store the metadata, its values should be bucketName/metadata | `/workflows/metadata` | +| `flyte-core.configmap.core.propeller.rawoutput-prefix` | to set the storage uri path to set store the raw output, its values should be bucketName/raw_data | `/workflows/raw_data` | +| `flyte-core.configmap.core.propeller.publish-k8s-events` | to publish kube events | `true` | +| `flyte-core.configmap.admin.admin.Command` | to set the external command | `["echo",""]` | +| `flyte-core.configmap.admin.admin.AuthType` | to set the auth type | `ExternalCommand` | +| `flyte-core.configmap.admin.admin.endpoint` | to set the endpoint | `` | +| `flyte-core.configmap.admin.admin.insecure` | to set the insecure flag | `false` | +| `flyte-core.configmap.admin.admin.AuthorizationHeader` | to set the authorization header type | `authorization` | +| `flyte-core.configmap.admin.event.rate` | to set the rate | `500` | +| `flyte-core.configmap.admin.event.type` | to set the type | `admin` | +| `flyte-core.configmap.admin.event.capacity` | to set the capacity | `100` | +| `flyte-core.configmap.logger.level` | to set the log level | `5` | +| `flyte-core.configmap.logger.show-source` | to set the log format | `true` | +| `flyte-core.flyteadmin.enabled` | to enable the flyteadmin | `false` | +| `flyte-core.datacatalog.enabled` | to enable the datacatalog | `false` | +| `flyte-core.flyteconsole.enabled` | to enable the flyteconsole | `false` | +| `flyte-core.flytepropeller.enabled` | to enable the flytepropeller | `true` | +| `flyte-core.flytepropeller.resources.limits.cpu` | to set the cpu limit | `1` | +| `flyte-core.flytepropeller.resources.limits.memory` | to set the memory limit | `800Mi` | +| `flyte-core.flytepropeller.resources.limits.ephemeral-storage` | to set the ephemeral storage limit | `2Gi` | +| `flyte-core.flytepropeller.resources.requests.cpu` | to set the cpu request | `0.5` | +| `flyte-core.flytepropeller.resources.requests.memory` | to set the memory request | `500Mi` | +| `flyte-core.flytepropeller.resources.requests.ephemeral-storage` | to set the ephemeral storage request | `1Gi` | +| `flyte-core.flytepropeller.serviceAccount.create` | to configure whether to create the service account or not | `true` | +| `flyte-core.flytepropeller.serviceAccount.annotations.eks.amazonaws.com/role-arn` | to set the role arn to access service account | `` | +| `flyte-core.workflow_scheduler.enabled` | to enable workflow scheduler | `false` | +| `flyte-core.workflow_notifications.enabled` | to enable the workflow notifications | `false` | +| `flyte-core.cluster_resource_manager.enabled` | to enable the cluster resource manager | `false` | ### tfySignedURLServer configurations