-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Cubed Sphere as P4estMesh
#689
Conversation
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 93.63% 93.70% +0.07%
==========================================
Files 171 171
Lines 16535 16712 +177
==========================================
+ Hits 15482 15659 +177
Misses 1053 1053
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general! just a few suggestions/questions/remarks from my side, but no blockers
10th point of #584.