-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GPU compatibility check in CI #2168
base: main
Are you sure you want to change the base?
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2168 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 483 483
Lines 38333 38333
=======================================
Hits 36943 36943
Misses 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I need thorough tests on all available OS x architecture. This will increase CI time, but it is necessary to ensure compatibility across all available resources. |
Review please @ranocha Thanks! |
Yes 😥 - I aimed to create an independent environment for each but forgot it is empty. |
Is the codecov issue fixed? The CI looks quite normal to me |
May I ask why we do not include tests for the 32 bit archs in the general CI? - Julia supports 32 bit on Linux and Windows |
The platforms are not used very often. Testing them in detail would add a huge amount of additional CI time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this - the name can be misleading since it does not perform any GPU compatibility tests running simulation etc.
Co-authored-by: Hendrik Ranocha <[email protected]>
This workflow will pass for Julia 1.10 but fail for Julia 1.11 so I restrict the test only to 1.10