-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new MPI custom ops in mpi reduce #2066
base: main
Are you sure you want to change the base?
Conversation
MPI.jl's reduce currently does not work for custom operators (such as Trixi's min/max) on ARM
Co-authored-by: Hendrik Ranocha <[email protected]>
macos-latest is 14, which is ARM
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bg/base_min_in_mpi_reduce #2066 +/- ##
=============================================================
- Coverage 96.32% 95.95% -0.37%
=============================================================
Files 470 470
Lines 37447 37449 +2
=============================================================
- Hits 36070 35934 -136
- Misses 1377 1515 +138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@vchuravy got it working! Despite one single very strange error involving vectorization... see CI. |
Follow-up to #2054