Ensure ~ operator converts to string #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2019 08:06
Ensure that the binary concatenation operator (~) always produces a string value. We do that by utilizing the string template syntax instead of the binary plus (+) operator in the transpiled code. To make the generated code more efficient and easier to read we'll also collapse sibling template literals into a single. fixes #123
|
@clivend could you take a look, please? |
krakenfuss
reviewed
Jun 25, 2019
| ) | ||
| ); | ||
| } | ||
| // path.replaceWithJS({ |
There was a problem hiding this comment.
This can then be removed, right?
added 2 commits
June 28, 2019 11:27
The correct Babel version includes spaces after { and before } when using template literal expressions.
|
hey @pago sorry I rarely check github notifications. I see that there are new tests for this operator that cover different scenarios, we should be good to go here :) |
|
hallo this is still open right? |
|
hallo all can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #123
What changed in this PR:
Ensure that the binary concatenation operator (~) always produces a string value.
We do that by utilizing the string template syntax instead of the binary plus (+) operator
in the transpiled code.
To make the generated code more efficient and easier to read we'll also collapse
sibling template literals into a single.