Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cull Straight Line Segments From Generated Paths #127

Open
Tyler-Lentz opened this issue Apr 1, 2024 · 0 comments
Open

Cull Straight Line Segments From Generated Paths #127

Tyler-Lentz opened this issue Apr 1, 2024 · 0 comments
Labels
feature New feature or request

Comments

@Tyler-Lentz
Copy link
Contributor

Tyler-Lentz commented Apr 1, 2024

If generated paths span large distances (e.g. entire continents) then there are two things that can potentially happen:

  1. Bandwidth issues: sending a path to the GCS/Pixhawk that has a lot of points will take a long time over the network.
  2. Performance issues: part of our logging code for the GCS routes logs out every request that is sent over the network. If a request contains a path with millions of points, then this takes a crazy long time.

2 can be fixed by just not logging the entire path, although it would require a refactoring of the GCS routes code because currently it assumes you want to log out the entirety of every HTTP request. However, 1 would always be a problem.

Both of these are incredibly minor problems and don't actually arise in the expected use case of the project (the size of mission that we would expect for the competition) but it still might be a good idea to implement the following to alleviate this:

  • When a path is generated, before saving in the MissionState vector remove from the vector of points all of the segments that are detected as straight lines, since it will be implied that any gaps in the generated points are straight lines.

This potentially could take a long time, so we would probably only want to enable this if we detect that the path has more than a certain amount of points where we end up saving time from the network transmission later.

@Tyler-Lentz Tyler-Lentz added the feature New feature or request label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant