Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing github action #2 #3

Open
5 tasks
trillium opened this issue Jul 12, 2023 · 0 comments
Open
5 tasks

Testing github action #2 #3

trillium opened this issue Jul 12, 2023 · 0 comments

Comments

@trillium
Copy link
Owner

v0.4 Setup Infrastructure

This ticket addresses eslint warnings for rules copied from the v0.3 branch.

Instructions

  • Review the rule documentation for the rule (see reference pages below)
  • Navigate the cli to the client folder
  • Run the lint script (e.g. npm run lint)
  • Review the results, noting all instances where the rule is referenced.
  • Address each warning using one of the following options, according to your best judgement:
    • use the npx eslint --fix --rule {rule to fix} command (not available for all rules)
    • correct the code according to the recommendations listed in the rule documentation
    • disable the rule for the reported line (NOTE: only use the disable instruction for a single line. Do NOT use the more global options). Include a comment for why this decision was made.
    • raise the rule as a topic to discuss with the group in the next meeting. We can then decide whether to edit or drop the rule, add more global disable flags, etc.

Acceptance Criteria

Running the lint script should result in an output that does not mention this rule (meaning all instances either corrected or marked for ignore).

Reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant