Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fourth batch of FreeBSD changes for the compliance test suite #915

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Fourth batch of FreeBSD changes for the compliance test suite #915

merged 9 commits into from
Nov 28, 2024

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Nov 25, 2024 •
edited
Loading 

test result: FAILED. 603 passed; 38 failed; 66 ignored; 0 measured; 0 filtered out; finished in 948.57s

error: test failed, to rerun pass `-p sudo-compliance-tests --lib`

Part of #869

@bjorn3 bjorn3 requested a review from squell November 25, 2024 16:24
@bjorn3 bjorn3 marked this pull request as draft November 26, 2024 08:51
@bjorn3 bjorn3 removed the request for review from squell November 26, 2024 08:51
@bjorn3
Remove broken test
9575366 
This removes a test that seemed like it checks that sudo doesn't set PS1
even when SUDO_PS1 is set in the case of a login shell. As it turns out
however, this behavior is caused by bash not inheriting PS1 to it's
children. If another shell is used, PS1 will be shown to be passed by
sudo to the elevated process even with og sudo.
@bjorn3
Use a consistent shell across OSes
c522684 
/bin/sh is the only shell that exists by default on both Linux and
FreeBSD. And also out of the installable shells the only shell which has
the same installation location on both OSes.
@bjorn3
Handle non-existent signal propagation of dash
d5c0f78 
If the dash shell receives a signal, it doesn't kill it's children. To
handle this, make sure the sh spawned by su execs the program that
should receive the signal.
@bjorn3
Handle differing cases where bash and dash exec the tail program
f664a17
@bjorn3 bjorn3 marked this pull request as ready for review November 26, 2024 13:48
@bjorn3 bjorn3 requested a review from squell November 26, 2024 13:48
squell
squell requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@squell squell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM, except for arg0_native_is_passed_from_commandline: removing the symlink there looks like it drastically changes the nature of the test.

test-framework/sudo-compliance-tests/src/sudo/path_search.rs Outdated Show resolved Hide resolved
@squell squell mentioned this pull request Nov 28, 2024
Merged
@bjorn3
Merge pull request #1 from trifectatechfoundation/fixup_compliance_test4
f77bdbc 
different approach to making this test crossplatform
@squell squell merged commit 87e51e9 into trifectatechfoundation:main Nov 28, 2024
13 checks passed
@bjorn3 bjorn3 deleted the freebsd_compliance_test4 branch November 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squell squell squell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @squell