Improve DX regarding service collection extension methods #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chucker
requested changes
Oct 14, 2024
TRENZ.Lib.RazorMail.Core/Extensions/RazorMailServiceCollectionExtensions.cs
Show resolved
Hide resolved
chucker
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was quite cumbersome to set the default headers now that they are available. That is because to set them, you need to get ahold of the
IMailClientinstance that will be used to send mails. To do that, you would have to set them somewhere decoupled from the DI container registration (bad because you can' guarantee the code only runs once) or you'd have to create your own instance (basically manually constructing the client instance).This PR changes that.
You can now pass a callback to the
AddMailKitMailClientorAddSystemNetMailClientextension methods and get full access to the constructed client.Apart from that I renamed some overloads to better match the services they register (and vice versa). No breaking changes though.