Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an updated lakeFS Python client in Spark integration tests #8391

Open
arielshaqed opened this issue Nov 21, 2024 · 3 comments · May be fixed by #8403
Open

Use an updated lakeFS Python client in Spark integration tests #8391

arielshaqed opened this issue Nov 21, 2024 · 3 comments · May be fixed by #8403
Labels
area/client/spark area/sdk/python area/system-tests Improvements or additions to the system-tests area/testing Improvements or additions to tests good first issue Good for newcomers python-wrapper tech-debt

Comments

@arielshaqed
Copy link
Contributor

test/spark/run-test.py still uses the legacy Python lakefs_client for setup. Given that it's deprecated, this is embarrassing and a tech debt. Update it to use the HL SDK lakefs, or at leask lakefs_sdk.
@arielshaqed arielshaqed added bug Something isn't working good first issue Good for newcomers area/testing Improvements or additions to tests area/system-tests Improvements or additions to the system-tests area/client/spark area/sdk/python tech-debt python-wrapper labels Nov 21, 2024
@arielshaqed
Copy link
Contributor Author

If you're looking for a small issue (1 day!) to help you understand lakeFSFS integration testing...

You've come to the right place!

@mahdikhashan
Copy link

@arielshaqed, I'd like to work on this one as well, I kindly request to assigning it to me to prevent any duplicate work. thank you

@mahdikhashan mahdikhashan linked a pull request Nov 29, 2024 that will close this issue
Open
@mahdikhashan
Copy link

I have a problem running the docker-compose for running the test inside it, you may find the attached image to this comment, I appreciate any help to run it (it seems the test run readme can be updated).

image

@itaiad200 itaiad200 removed the bug Something isn't working label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/client/spark area/sdk/python area/system-tests Improvements or additions to the system-tests area/testing Improvements or additions to tests good first issue Good for newcomers python-wrapper tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace lakefs_client with lakefs-sdk in Spark integration test harness mahdikhashan/lakeFS
3 participants
@arielshaqed @itaiad200 @mahdikhashan