From a09c4b87f83a880d75f343ff195438f0281fcccc Mon Sep 17 00:00:00 2001 From: Martin Hutchinson Date: Thu, 5 Dec 2024 14:15:40 +0000 Subject: [PATCH] Added comment to related method --- cmd/conformance/mysql/main.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/conformance/mysql/main.go b/cmd/conformance/mysql/main.go index 21103abb..2fe58d08 100644 --- a/cmd/conformance/mysql/main.go +++ b/cmd/conformance/mysql/main.go @@ -207,6 +207,9 @@ func configureTilesReadAPI(mux *http.ServeMux, storage *mysql.Storage) { } // TODO: Add immutable Cache-Control header. + // Only do this once we're sure we're returning the right number of entries + // Currently a user can request a full tile and we can return a partial tile. + // If cache headers were set then this could cause caches to be poisoned. if _, err := w.Write(entryBundle); err != nil { klog.Errorf("/tile/entries/{index...}: %v", err)