Break out tcf URLs and dataRetention into their own codecs #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadDataScience
previously approved these changes
Sep 15, 2023
src/iab.ts
Outdated
Comment on lines
130
to
137
| export const TcfGvlV3Urls = t.array( | ||
| t.intersection([ | ||
| t.type({ langId: t.string, privacy: t.string }), | ||
| t.partial({ | ||
| legIntClaim: t.string, | ||
| }), | ||
| ]), | ||
| ); |
There was a problem hiding this comment.
I find
Suggested change
| export const TcfGvlV3Urls = t.array( | |
| t.intersection([ | |
| t.type({ langId: t.string, privacy: t.string }), | |
| t.partial({ | |
| legIntClaim: t.string, | |
| }), | |
| ]), | |
| ); | |
| export const TcfGvlV3Url = t.intersection([ | |
| t.type({ langId: t.string, privacy: t.string }), | |
| t.partial({ | |
| legIntClaim: t.string, | |
| }), | |
| ]); |
a little more flexible. It's easier to wrap a type in t.array than to unravel it if you need.
src/iab.ts
Outdated
| ]), | ||
| ), | ||
| dataRetention: TcfGvlV3DataRetention, | ||
| urls: TcfGvlV3Urls, |
There was a problem hiding this comment.
Suggested change
| urls: TcfGvlV3Urls, | |
| urls: t.array(TcfGvlV3Url), |
following the above suggestion.
There was a problem hiding this comment.
Ahhh it much more flexible now! I made the change and it should be ready for re-review! Thanks!
delete-merged-branch
bot
deleted the
linh-transcend/make-codecs-tcf-urls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]