Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendors list v3 feature #92

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

linh-transcend
Copy link
Member

Related Issues

  • [none]

Security Implications

[none]

System Availability

[none]

@linh-transcend linh-transcend requested review from a team and MadDataScience September 7, 2023 16:03
Copy link
Contributor

@MadDataScience MadDataScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me, an alternative approach would be to make illustrations optional. i.e.:

export const TcfGvlV3Purpose = t.union([
  t.type({
    id: t.number,
    name: t.string,
    description: t.string,
  }),
  t.partial({
    illustrations: t.array(t.string),
  }),
]);

I think what you have is maybe better, as it was, arguably, a bit odd to be calling "purposes" "features" anyway. Just thinking outloud.

@linh-transcend
Copy link
Member Author

I also separated the types in the main repo so that was another reason I separated the purposes and features too!

@linh-transcend linh-transcend merged commit 88944ca into main Sep 7, 2023
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the linh-transcend/update-tcf-gvl3-features branch September 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants