Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR infringement #137

Open
rschrenk opened this issue Feb 1, 2022 · 1 comment
Open

GDPR infringement #137

rschrenk opened this issue Feb 1, 2022 · 1 comment

Comments

@rschrenk
Copy link

rschrenk commented Feb 1, 2022

Hello,

we recognized, that qtype_coderunner uses Google APIs in

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
just to load AJAX, which is available in Moodle anyway by using require(['core/ajax'], function($) {}).

As for European sites, this causes an infringement of the GDPR. Would it be possible to fix that?

Kind regards

@mckeownp
Copy link
Collaborator

mckeownp commented Jan 16, 2024

Hi,

thanks for pointing this out.

This issue was fixed not long after it was posted but it wasn't closed off here. So I'm doing that now :)

See the e0f47b9 commit for details.

There is a small typo (see if you can spot it) that means the expand/collapse buttons don't update from collapse to expand. This isn't a critical bug as the page is still usable, so we'll roll out the fix with other updates.

Cheers,
Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants