Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if invalid JSON is returned #1

Open
JacenBoy opened this issue Mar 20, 2019 · 0 comments
Open

Crash if invalid JSON is returned #1

JacenBoy opened this issue Mar 20, 2019 · 0 comments

Comments

@JacenBoy
Copy link

node-kitsu seems to assume that the Kitsu API will always return a proper JSON response. If the API does not return a proper JSON response, a syntax error is thrown during the parsing of the response.

I am currently using async/await syntax wrapped in a try/catch, and the syntax error seems to occur outside of my try/catch, causing the app to crash.

The issue can be recreated if a request is made while Kitsu is experiencing some kind of downtime. Rather than a JSON response, the API returns an HTML error page, causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant