Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted jemalloc to submodule #65

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

paviad
Copy link
Contributor

@paviad paviad commented Jun 24, 2020

This PR converts jemalloc into a submodule which prevents code copying and enables rebasing on jemalloc/jemalloc and being able to benefit from bug fixes on that repo.

This PR is not to be merged blindly, it removes the jemalloc copy and replaces it with a submodule. The submodule currently points to my own fork of tporadowski/jemalloc --> paviad/jemalloc and points to a commit which is based on jemalloc master branch and brings it to the same state as it was in the original tporadowski/redis/develop branch.

So if you want to use this PR, you should first create a redis branch on tporadowski/jemalloc apply the 4 commits from the redis branch of paviad/jemalloc and then add it as a submodule.

@tporadowski
Copy link
Owner

Thanks, will have a look at it! I was once thinking of using submodules, but have no experience with them in Git and as far as I remember - they're not as easy as Subversion's svn:externals ;)

@tporadowski tporadowski mentioned this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants