From f715323c0e57fe64be00e38e3436dd5b00f2bba0 Mon Sep 17 00:00:00 2001 From: Tim Pilius Date: Sun, 26 May 2024 18:15:04 -0400 Subject: [PATCH] Updating editorconfig --- .editorconfig | 9 ++++++++- BattleNetPrefill/Properties/launchSettings.json | 2 +- BattleNetPrefill/Web/CdnRequestManager.cs | 1 - 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.editorconfig b/.editorconfig index a2632127..a7c6712e 100644 --- a/.editorconfig +++ b/.editorconfig @@ -86,8 +86,15 @@ dotnet_style_prefer_collection_expression = false # IDE0090 : 'new' expression can be simplified csharp_style_implicit_object_creation_when_type_is_apparent = false +# IDE0290: Use primary constructor +# - I'm a fan of this syntax in Typescript, but it still feels a bit too jarring seeing it C# now +csharp_style_prefer_primary_constructors = true + + # Banned APIs will be bumped up to an error instead of warning dotnet_diagnostic.rs0030.severity = error # The method does not need to use async/await - Introduces annoying 'return' statements for async methods, that hurt code readability. -dotnet_diagnostic.AsyncFixer01.severity = none \ No newline at end of file +dotnet_diagnostic.AsyncFixer01.severity = none + + diff --git a/BattleNetPrefill/Properties/launchSettings.json b/BattleNetPrefill/Properties/launchSettings.json index 59f0f6b2..440b6fa3 100644 --- a/BattleNetPrefill/Properties/launchSettings.json +++ b/BattleNetPrefill/Properties/launchSettings.json @@ -6,7 +6,7 @@ }, "Prefill Test Products - No Download": { "commandName": "Project", - "commandLineArgs": "prefill -p s1 s2 pro wow wow_classic --no-download --force" + "commandLineArgs": "prefill -p s1 s2 pro wow wow_classic --no-download --force --verbose" }, "Prefill All - No Download - No Cache": { "commandName": "Project", diff --git a/BattleNetPrefill/Web/CdnRequestManager.cs b/BattleNetPrefill/Web/CdnRequestManager.cs index 792fef9e..144441ee 100644 --- a/BattleNetPrefill/Web/CdnRequestManager.cs +++ b/BattleNetPrefill/Web/CdnRequestManager.cs @@ -25,7 +25,6 @@ public sealed class CdnRequestManager : IDisposable /// private string _productBasePath; - //TODO why is this a dictionary of requests? private readonly List _queuedRequests = new List(); #region Debugging