From c6e49c98233c42601f103400bcc0c76e6335bc0c Mon Sep 17 00:00:00 2001
From: Tim Pilius <tpilius@gmail.com>
Date: Tue, 7 May 2024 12:22:32 -0400
Subject: [PATCH] Misc cleanup

---
 BattleNetPrefill/BattleNetPrefill.csproj         | 12 ++++++++----
 BattleNetPrefill/Handlers/DownloadFileHandler.cs |  1 +
 BattleNetPrefill/Program.cs                      |  3 ++-
 BattleNetPrefill/Properties/launchSettings.json  | 12 ++++--------
 4 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/BattleNetPrefill/BattleNetPrefill.csproj b/BattleNetPrefill/BattleNetPrefill.csproj
index c3b44c2a..20cf8327 100644
--- a/BattleNetPrefill/BattleNetPrefill.csproj
+++ b/BattleNetPrefill/BattleNetPrefill.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-    <RuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx-x64</RuntimeIdentifiers>  
+    <RuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx-x64</RuntimeIdentifiers>
     <OutputType>Exe</OutputType>
 
     <AssemblyName>BattleNetPrefill</AssemblyName>
@@ -19,15 +19,14 @@
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
   </PropertyGroup>
 
-    <!-- Publish Settings -->
+  <!-- Publish Settings -->
   <PropertyGroup>
     <PublishTrimmed>true</PublishTrimmed>
     <EnableTrimAnalyzer>true</EnableTrimAnalyzer>
     <TrimmerSingleWarn>false</TrimmerSingleWarn>
     <!-- Reverts back to the default trim mode used by dotnet 6, otherwise CliFx breaks without reflection -->
     <TrimMode>partial</TrimMode>
-    
-    <PublishReadyToRun>true</PublishReadyToRun>
+
     <PublishSingleFile>true</PublishSingleFile>
 
     <!-- Required to be enabled in order to run this application on Ubuntu Docker images. -->
@@ -51,6 +50,11 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <DebugType>none</DebugType>
     <DebugSymbols>false</DebugSymbols>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- Removes the full file system path from exception stack traces, only shows the file names now -->
+    <PathMap>$(MSBuildProjectDirectory)=$(MSBuildProjectName)</PathMap>
   </PropertyGroup>
 
   <!-- Includes Linux update script in publish package -->
diff --git a/BattleNetPrefill/Handlers/DownloadFileHandler.cs b/BattleNetPrefill/Handlers/DownloadFileHandler.cs
index 40d9fd1a..f79f4801 100644
--- a/BattleNetPrefill/Handlers/DownloadFileHandler.cs
+++ b/BattleNetPrefill/Handlers/DownloadFileHandler.cs
@@ -99,6 +99,7 @@ private int ReadHeader(BinaryReader bin)
             return entryExtra;
         }
 
+        //TODO this name is awful, maybe change it to something like BuildDownloadList or similar
         /// <summary>
         /// Determines which files need to be downloaded, and queues them for download.
         /// </summary>
diff --git a/BattleNetPrefill/Program.cs b/BattleNetPrefill/Program.cs
index a207d352..685b5609 100644
--- a/BattleNetPrefill/Program.cs
+++ b/BattleNetPrefill/Program.cs
@@ -1,8 +1,9 @@
 namespace BattleNetPrefill
 {
-    // TODO - Add publish build pipeline 
+    // TODO - Add publish build pipeline
     // TODO - Setup mkdocs and copy from SteamPrefill.  Update docs in general
     // TODO warcraft 3 hangs for some reason on retreiving uncached archive indexes
+    //TODO add total download size to summary
     public static class Program
     {
         private const string Description = "Automatically fills a Lancache with games from Battle.Net, so that subsequent downloads will be \n" +
diff --git a/BattleNetPrefill/Properties/launchSettings.json b/BattleNetPrefill/Properties/launchSettings.json
index 6681fb80..1e32375d 100644
--- a/BattleNetPrefill/Properties/launchSettings.json
+++ b/BattleNetPrefill/Properties/launchSettings.json
@@ -1,13 +1,9 @@
 {
   "profiles": {
-    "Prefill Blizzard - No Cache - No Download": {
+    "Prefill All - No Download": {
       "commandName": "Project",
       "commandLineArgs": "prefill --all --no-download --force"
     },
-    "Prefill Games used for testing": {
-      "commandName": "Project",
-      "commandLineArgs": "prefill -p zeus  --nocache"
-    },
     "Prefill Starcraft 1": {
       "commandName": "Project",
       "commandLineArgs": "prefill -p s1 --force"
@@ -18,15 +14,15 @@
     },
     "Prefill WOW - Compare Requests": {
       "commandName": "Project",
-      "commandLineArgs": "prefill -p wow_classic --compare-requests --no-download --force"
+      "commandLineArgs": "prefill -p s1 --compare-requests --no-download --force"
     },
     "Select Apps": {
       "commandName": "Project",
       "commandLineArgs": "select-apps"
     },
-    "Prefill Selected": {
+    "Prefill Selected - No download": {
       "commandName": "Project",
-      "commandLineArgs": "prefill"
+      "commandLineArgs": "prefill --no-download --force"
     },
     "Clear Cache - Accept": {
       "commandName": "Project",