Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloneDeep function copy AbortController function is incorrect #848

Open
vxow opened this issue Nov 26, 2024 · 2 comments · May be fixed by #892
Open

cloneDeep function copy AbortController function is incorrect #848

vxow opened this issue Nov 26, 2024 · 2 comments · May be fixed by #892

Comments

@vxow
Copy link

vxow commented Nov 26, 2024 

const controller = new AbortController()
const signal = controller.signal
console.log(isEqual(signal, cloneDeep(signal))) // false
@raon0211
Copy link
Collaborator

Let us look into this issue!

@D-Sketon D-Sketon linked a pull request Dec 8, 2024 that will close this issue
Open
@raon0211
Copy link
Collaborator

Hello, is there a specific use case for supporting this behavior? I'm asking because usually two cloned objects are not equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(isEqual): isEqual should compare AbortController D-Sketon/es-toolkit
2 participants
@raon0211 @vxow