Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the parameter rollout_length settings #9

Open
nicholas0717 opened this issue Oct 25, 2022 · 2 comments
Open

About the parameter rollout_length settings #9

nicholas0717 opened this issue Oct 25, 2022 · 2 comments

Comments

@nicholas0717
Copy link

nicholas0717 commented Oct 25, 2022

Hi @toshikwa :

I'm trying to implement other tasks with your GAIL framework, but it works badly. I think the network units and relevant parameters I chose are not appropriate. I have some questions.

I want to know how to choose the rollout_length for different tasks. You chose 2000 for InvertedPendulum-v2 and 50000 for Hopper-v3. Is there a criterion for choosing rollout_length?

The hidden_activation you chose are all Tanh() in discriminator, actor, critic. Is it better than ReLU() in GAIL? And will the hidden_units affect the final performance of the agent a lot?

Last question. In your Hopper-v3 example, the final acc_exp and acc_pi is shown below. But in my task, the Accuracy Exp is approaching 1. Is there something wrong with this?

image
image

Hope you can give me some advice. Thank you so much.

@Charlesyyun
Copy link

Hi nicholas, I have also tried the code on my task. It turns out that the results are unsatisfying. Did you find a way out?

@JimberZ
Copy link

JimberZ commented May 9, 2023

Hi nicholas, I have also tried the code on my task. It turns out that the results are unsatisfying. Did you find a way out?

so do i, Did you find a way out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants