Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging both http- and quic-level events #21

Open
kazuho opened this issue Mar 4, 2020 · 2 comments
Open

logging both http- and quic-level events #21

kazuho opened this issue Mar 4, 2020 · 2 comments

Comments

@kazuho
Copy link
Contributor

kazuho commented Mar 4, 2020

At the moment, the command is capable of only logging either of the two at once. This prevents us from doing cross-layer analysis, e.g, looking into what HTTP response is sent on a particular QUIC STREAM frame.

I think we should simply log all the events regardless of the layer (e.g., provider in terms of USDT).

When emitting events from multiple providers to JSON, the event names can be prefixed by their prefixes (e.g., receive event of quicly provider becomes quicly_receive). Doing so would align the output to that generated by https://github.com/h2o/quicly/blob/master/misc/probe2trace.pl.

@toru
Copy link
Owner

toru commented Mar 4, 2020

Thank you for the feature request. This sounds like a lovely way to support the core development of H2O, as well as empowering system operators to make informed tuning decisions.

@kazuho
Copy link
Contributor Author

kazuho commented Jun 9, 2020

See also #83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants