-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake C++ GTK 3 Community Template #278
base: dev
Are you sure you want to change the base?
Conversation
8a22c14
to
ed27c67
Compare
Tested on This PR is ready for review. |
1d12caa
to
0490422
Compare
Create a template for GTK 3, based on the cmakeConsole. Use the "torizon/wayland-gtk3" container as base for the runtime. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
0490422
to
dfe452b
Compare
This is a Community template fostered by Toradex. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
cmakeGTK3/Dockerfile
Outdated
RUN apt-get -q -y update && \ | ||
apt-get -q -y install \ | ||
cmake \ | ||
libgtk-3-dev:${IMAGE_ARCH} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found out that this does not work because for arm32, IMAGE_ARCH
is arm
, but apt
uses :armhf
. But this is a use case we need to support, not just for this template but for any template. Here there are two possible options:
- Use
if
for the install, like in here - Modify the templates to have a
torizonPackages.json
, instead of creating it on project creation, to have at least the dependencies that depend on the architecture there
Probably will be nice to quickly discuss this on a meeting (like on the grooming)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the templates to have a torizonPackages.json, instead of creating it on project creation, to have at least the dependencies that depend on the architecture there
I like it. In fact, in my tests I was using the torizonPackages.json
but then in the template I didn't use it because I thought this was a file that was mandatory to be left empty in the template. More or less like:
- Keep the base required files for the template to work on the Dockerfile directly
- Keep the
torizonPackages.json
only for the user
But not sure what makes most sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed with ddf6eae
Cross compilation had some issues with the GTK 4 template due to Debian dependencies. To keep the GTK 3 and GTK 4 templates as close as possible, move both to using native compilation (with the help of QEMU emulation). This also solves an issue with 32-bit Arm cross-compilation specific to the IDE Templates variable substitution. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
Create a CMake C++ GTK 3 community template (sponsored by Toradex, but not regularly maintained like the Toradex-supported ones).
This template is based on the cmakeConsole and modified inspired on the cppQML for enabling graphics.
This PR is a fork of #268 and depends on toradex/vscode-torizon-templates-documentation#16