cppSlint and rustSlint production Dockerfile fixes + Github Actions Checks #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm setting this as draft because I think that is time to take advantage to implement some Github Actions tests to not have this fails again. |
tronical
reviewed
Sep 1, 2023
microhobby
force-pushed
the
castello/slint
branch
from
38d4ba6 to
55eb1cf
Compare
For the production image we need to use the default torizon/wayland-base image as base, because we do not need any other development tool, we are only shipping the slint binary. Signed-off-by: Matheus Castello <[email protected]>
microhobby
force-pushed
the
castello/slint
branch
9 times, most recently
from
897dfaf to
f750f7f
Compare
microhobby
changed the title
For the production image we need to use the default torizon/wayland-base mage as base, because we do not need any other development tool, we are only shipping the application. Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
microhobby
force-pushed
the
castello/slint
branch
from
f750f7f to
92ff7e0
Compare
Signed-off-by: Matheus Castello <[email protected]>
microhobby
requested review from
tronical
and removed request for
tronical and
andreriesco
tronical
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #95
fixes #101
fixes #97