Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/356 #357

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Issue/356 #357

merged 1 commit into from
Jun 25, 2019

Conversation

vecna
Copy link
Contributor

@vecna vecna commented Jun 25, 2019

this address #356

  • small requirements.txt update (please review)
  • small script update (tested)

@vecna vecna requested a review from evilaliv3 June 25, 2019 15:13
@@ -1,8 +1,7 @@
Parsley==1.2
Twisted==16.0.0
cffi==1.5.2
cryptography==1.2.3
enum34==1.1.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two changes are incorrect. they should be reverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed commit! going to merge!

@evilaliv3
Copy link
Contributor

good to go @vecna !

@evilaliv3 evilaliv3 merged commit b6f979c into master Jun 25, 2019
@evilaliv3 evilaliv3 deleted the issue/356 branch June 25, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants