Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

chore(typescript): convert tests to use typescript as well #112

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

PeterMK85
Copy link
Contributor

Description

Describe the changes and motivations for the pull request, unless obvious from the title.

Review

  • Verify that all classes affected by the changes have good top-level documentation.
  • Verify that new code has been covered with specs (and features if applicable).
  • Verify that a corresponding meaningful changelog entry has been added (* Add Github pull request template), for this change if applicable.
  • Test manually.
  • Get two 👍 from code review.

Pre-merge checklist

  • The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
  • Verify that all new dependencies are included in package.json.
  • Double check the quality of commit messages.
  • Squash related commits together.
  • Verify the branch name starts with NNNN where NNNN is the issue number.

Screenshots

Before After
Insert screenshots and/or screen recordings Insert screenshots and/or screen recordings

Other

Provide additional notes, remarks, links, mention specific people to review,…

@havenchyk
Copy link
Contributor

I don’t see benefit in this change, let simply rewrite tests with TS

@PeterMK85
Copy link
Contributor Author

@havenchyk
You mean to have tests in TS? I think on a longer run, it beneficial because this is actually a proper way to test. (Props has been passed with a proper type... etc)

@havenchyk
Copy link
Contributor

@PeterMK85 I mean #104 currently tests are not really reliable, I started rewriting them, but it's in early state

@PeterMK85
Copy link
Contributor Author

I would merge this and the prettier PR in, and we would have a base with the desired TS base, with the desired code formatting.

And than we can start to create FCs with test coverage.

IMHO of course
@havenchyk

@havenchyk
Copy link
Contributor

You’re a maintainer so it’s up to you. I don’t see benefits on migrating specs or applying code style to something that is going to be removed

@PeterMK85
Copy link
Contributor Author

We have multiple this (like class components, spread logic, but because we don't want to do it in a single PR, we need to start somehow)

@PeterMK85 PeterMK85 merged commit 0f23903 into master Nov 1, 2019
@PeterMK85 PeterMK85 deleted the transform-tests-typescript branch November 1, 2019 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants