Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip needrestart if Pacman Hook is Installed #993

Open
2 of 6 tasks
RayJW opened this issue Dec 3, 2024 · 0 comments
Open
2 of 6 tasks

Skip needrestart if Pacman Hook is Installed #993

RayJW opened this issue Dec 3, 2024 · 0 comments
Labels
C-bug Something isn't working

Comments

@RayJW
Copy link

RayJW commented Dec 3, 2024

Not sure whether this is actually a bug, or maybe it would make more sense to label this as a feature request.

Erroneous Behavior

Per default, the needrestart package from the AUR installs a pacman hook which runs needrestart on every upgrade. I assume this would be the most common install method for needrestart users on Arch.

Expected Behavior

Maybe it would make sense to check if this hook is present and skip the needrestart step, if it is. Usually that would either be in /usr/share/libalpm/hooks or /etc/pacman.d/hooks.

Steps to reproduce

  1. Install the needrestart package from the AUR
  2. Run topgrade where a package gets upgraded
  3. Observe topgrade running needrestart twice, once as the pacman hook, and the other time as a separate step

Problem persists without calling from topgrade

  • Yes
  • No

Did you run topgrade through Remote Execution

  • Yes
  • No

If yes, does the issue still occur when you run topgrade directly in your
remote host

  • Yes
  • No

Additional Details

  • Operation System/Version: CachyOS

  • Installation: Cargo

  • Topgrade version (topgrade -V): topgrade 16.0.1

Verbose Output (topgrade -v)

── 12:40:24 - System update ────────────────────────────────────────────────────
DEBUG Cannot find "powerpill"
DEBUG Cannot find "garuda-update"
DEBUG Detected "/usr/bin/paru" as "paru"
DEBUG Executing command `/usr/bin/paru -Pw`
no new news
DEBUG Executing command `/usr/bin/paru --pacman pacman -Syu --noconfirm`
:: Synchronising package databases...
 cachyos-v3 is up to date
 cachyos-core-v3 is up to date
 cachyos-extra-v3 is up to date
 cachyos is up to date
 core is up to date
 extra is up to date
 multilib is up to date
:: Starting full system upgrade...
 there is nothing to do
:: Looking for PKGBUILD upgrades...
:: Looking for AUR upgrades...
:: Looking for devel upgrades...
:: marked out of date: davinci-resolve-studio
:: orphans: swaylock-corrupter
 there is nothing to do
DEBUG Step "pihole"
@RayJW RayJW added the C-bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant