Additional Git repositories not expanding environment variables like $HOME or ~

[j-lakeman]

Erroneous Behavior

Within the [git] section of topgrade.toml,

repos = ["/home/xxx/Documents/Git/*"] is expanded, whereas

repos = ["$HOME/Documents/Git/*"] as well as
repos = ["~/Documents/Git/*"] or
repos = ["$GIT/*"] don't expand.

Expected Behavior

all of the above expand properly (subdirectories of Git/ as well as environment variables)

Steps to reproduce

alter topgrade.toml accordingly

Possible Cause (Optional)

shell or topgrade don't expand variables

Did you run topgrade through Remote Execution

• Yes
• No

Configuration file (Optional)

[git]
# How many repos to pull at max in parallel
# max_concurrency = 5

# Additional git repositories to pull
repos = ["~/Documents/Git/*"]

# Don't pull the predefined git repos
# pull_predefined = false

# Arguments to pass Git when pulling Repositories
arguments = "--autostash"

Additional Details

• Operation System/Version
  openSUSE Tumbleweed, Debian Sid, macOS

• Installation
  package manager (zypper, apt, brew)

• Topgrade version (topgrade -V)
  Topgrade 15.0.0

Verbose Output (topgrade -v)

DEBUG Executing command `/usr/bin/git rev-parse --show-toplevel`
Path ~/Documents/Git/* did not contain any git repositories

I should probably also mention that I'm tracking my entire home directory with Git, so the Git directories above are nested.

[j-lakeman]

Possibly related:

• Emacs Snapshot step: "cp: ~/.emacs.d/elpa: No such file or directory" #885
• --only wsl calls ~/.cargo/bin/cargo-install-update without PATH=/home/<username>/.cargo/bin/:.. set #862

[SteveLauC]

Hi, from my test ~ and * will be expanded, environment variables are indeed unsupported, so:

• $HOME/Documents/Git/*: won't work
• ~/Documents/Git/*: should work
• $GIT/*: won't work

[SteveLauC]

Thanks for searching existing issues before filing a new one:)

Possibly related:

• Emacs Snapshot step: "cp: ~/.emacs.d/elpa: No such file or directory" #885

Topgrade currently won't expand the strings configured in custom commands, they are directly passed to user's $SHELL, the shell used by this issue's author, won't expand ~, so this issue happens.

• --only wsl calls ~/.cargo/bin/cargo-install-update without PATH=/home/<username>/.cargo/bin/:.. set #862

This issue is possibly because a log-in shell won't have the config set in an interactive shell, so it cannot see the $HOME variable.

[SteveLauC]

environment variables are indeed unsupported

Topgrade uses shellexpand to do the expansion of the shell stuff, like ~, currently, we are using shellexpand::tlide(), which only expands ~, if we replace shellexpand::tlide() with shellexpand::full(), both ~ and environment variables expansion will be supported.

[j-lakeman]

* `~/Documents/Git/*`: should work

Tried that and it still doesn't work. I should probably also mention that ~/Documents is a symlink in my case which still shouldn't matter right?

Topgrade uses shellexpand to do the expansion of the shell stuff, like ~, currently, we are using shellexpand::tlide(), which only expands ~, if we replace shellexpand::tlide() with shellexpand::full(), both ~ and environment variables expansion will be supported.

Would be awesome if environment variables expansion could be supported!

[j-lakeman]

Thanks for searching existing issues before filing a new one:)

Of course!

Possibly related:

• Emacs Snapshot step: "cp: ~/.emacs.d/elpa: No such file or directory" #885

Topgrade currently won't expand the strings configured in custom commands, they are directly passed to user's $SHELL, the shell used by this issue's author, won't expand ~, so this issue happens.

• --only wsl calls ~/.cargo/bin/cargo-install-update without PATH=/home/<username>/.cargo/bin/:.. set #862

This issue is possibly because a log-in shell won't have the config set in an interactive shell, so it cannot see the $HOME variable.

Thanks for clarifying!