remove future before setting value by default

tootedom · Sep 25, 2016 · 5c92c94 · 5c92c94
1 parent 7894a72
commit 5c92c94
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...rg/greencheek/caching/herdcache/memcached/config/builder/MemcachedCacheConfigBuilder.java b/...rg/greencheek/caching/herdcache/memcached/config/builder/MemcachedCacheConfigBuilder.java
@@ -52,7 +52,7 @@ public abstract class MemcachedCacheConfigBuilder<T extends MemcachedCacheConfig
     private String staleCachePrefix = "stale";
     private int staleMaxCapacity = -1;
     private Duration staleCacheMemachedGetTimeout = Duration.ZERO;
-    private boolean removeFutureFromInternalCacheBeforeSettingValue = false;
+    private boolean removeFutureFromInternalCacheBeforeSettingValue = true;
     private boolean hashKeyPrefix = true;
     private Duration waitForRemove = Duration.ZERO;
     private MetricRecorder metricRecorder = new NoOpMetricRecorder();

diff --git a/src/test/java/org/greencheek/caching/herdcache/memcached/TestSimpleMemcachedCaching.java b/src/test/java/org/greencheek/caching/herdcache/memcached/TestSimpleMemcachedCaching.java
@@ -1469,6 +1469,7 @@ public void testDoNotUseCachedValue() {
                         .setProtocol(ConnectionFactoryBuilder.Protocol.TEXT)
                         .setWaitForMemcachedSet(true)
                         .setKeyHashType(KeyHashingType.SHA256_UPPER)
+                        .setRemoveFutureFromInternalCacheBeforeSettingValue(true)
                         .setMetricsRecorder(new YammerMetricsRecorder(registry))
                         .buildMemcachedConfig()
         );