Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration metrics not following Prometheus best practices #203

Open
hypery2k opened this issue Jun 14, 2021 · 0 comments
Open

Duration metrics not following Prometheus best practices #203

hypery2k opened this issue Jun 14, 2021 · 0 comments

Comments

@hypery2k
Copy link
Contributor

hypery2k commented Jun 14, 2021

Bug Report

I was browsing the documentation on Proxy Metrics, and noticed some of the metrics don't follow Prometheus naming best practices. In particular this concerns the metrics regarding durations_

security_ssl_expire_days_remaining use base unit "seconds" instead of "days"

What is the issue?

Typically durations are described with the word duration within the metric name. (this one might just be personal taste, but it's the most frequently used and encouraged one one)
The metrics are not in base unit (seconds) but they are in milliseconds. This makes is difficult to work with various other component's metrics values as you need to convert to base unit.
Possible solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant