Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom logical type with value class implementation #64

Open
jangalinski opened this issue May 30, 2024 · 1 comment
Open

Support custom logical type with value class implementation #64

jangalinski opened this issue May 30, 2024 · 1 comment
Labels
Type: enhancement New feature or request

Comments

@jangalinski
Copy link
Contributor

Problem: Customer has an id ... this is a string (or uuid). We want to use this id in a type-safe, ddd way, thus we need a CustomerId. could define this as a record, but since we are not allowed to reuse schema definitions from another schema, we woul have n definitions of this CustomerId record.
If we just provide it via conversion, we need to distribute libs containing the CustomerId.

Idea: Define a logical-type "value-id" and generate a value class based on naming conventions, so the type is alway present when we generate objects from schema.

Currently fails with value class CustomerId because of internal avro4k String/Charsequence erasure.

@jangalinski jangalinski added the Type: enhancement New feature or request label May 30, 2024
@jangalinski
Copy link
Contributor Author

jangalinski commented Jul 14, 2024

Currently fails with value class CustomerId because of internal avro4k String/Charsequence erasure.

This is fixed with 1.11.4.4, but the code generation part is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant