Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single .kt file output without nested classes for schema generator #143

Closed
jangalinski opened this issue Sep 18, 2024 · 0 comments
Closed
Labels
Prio: MUST Must be implemented in this milestone Type: enhancement New feature or request
Milestone

Comments

@jangalinski
Copy link
Contributor

jangalinski commented Sep 18, 2024

When we generate (data) classes from schema, we still use a RootDataClass strategy with nested sub classes for embedded types.
This is not a good idea as the FQN of the inner class does not macht the FQN of the schema (see #138).

TODO: AS we do with protocol already, rewrite the generator for AvroSchemaDeclaration to create a single kotlin source file that contains all types mentioned in the schema, but without nesting.

This is a breaking change, so we rename the milstone to 1.12.4.0

@jangalinski jangalinski added the Type: enhancement New feature or request label Sep 18, 2024
@jangalinski jangalinski changed the title Single kt file output without nested classes for schema generator Single .kt file output without nested classes for schema generator Sep 18, 2024
@jangalinski jangalinski added this to the 1.12.3.1 milestone Sep 18, 2024
@jangalinski jangalinski added the Prio: MUST Must be implemented in this milestone label Sep 18, 2024
jangalinski added a commit that referenced this issue Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: MUST Must be implemented in this milestone Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant