Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to replace ffmpeg command with a custom path #81

Open
ubershmekel opened this issue Oct 4, 2020 · 2 comments · May be fixed by #83 or #85
Open

Allow users to replace ffmpeg command with a custom path #81

ubershmekel opened this issue Oct 4, 2020 · 2 comments · May be fixed by #83 or #85

Comments

@ubershmekel
Copy link

ubershmekel commented Oct 4, 2020

I don't know why, but just setting process.env.path didn't work for me when building on Netlify.

You can see what troubles I got into here: https://github.com/ubershmekel/ld47/blob/master/build/build-sounds.js

I ended up copying the audiosprite.js file and modifying it to allow using a custom ffmpeg binary file path.

@endel endel linked a pull request Jul 31, 2021 that will close this issue
@endel
Copy link
Contributor

endel commented Jul 31, 2021

Created a PR to address this #83

(In the meantime, you can use @gamestdio/audiosprite package with this feature)

@tdukart tdukart linked a pull request Feb 12, 2022 that will close this issue
@tdukart
Copy link

tdukart commented Feb 12, 2022

I didn't see #83, but I took a different approach with another PR, #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants