Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot go back using alchemist-goto-jump-back(M-,). #376

Open
wettoast4 opened this issue Aug 17, 2024 · 0 comments
Open

Cannot go back using alchemist-goto-jump-back(M-,). #376

wettoast4 opened this issue Aug 17, 2024 · 0 comments

Comments

@wettoast4
Copy link

Phenomenon:
After jumping to a different location using 'M-.' (alchemist-goto-definition-at-point), I expected that 'M-,' would restore the original location, but the minibuffer displayed 'At start of xref history'.

Suggested solution:
This seems to be related to that 'find-tag-marker-ring' function is obsolete (Obsolete in Emacs 25.1, released in Sep 2016 ). I think the following fix to the lines 140 and 222 in bodies of 'alchemist-goto-list-symbol-definitions' and 'alchemist-goto--open-definition' functions in alchemist-goto.el will get it work. But I'm not confident if this modification does not affect other parts because I have less experience on ELISP language. Please point out if I'm wrong.

before fix: (ring-insert find-tag-marker-ring (point-marker))
after fix: (xref-push-marker-stack (point-marker))

versions I used:

  • Alchemist version: 1.8.2 (package: 20180312.1304)
  • Emacs version: GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.42, cairo version 1.18.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant