Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety condition review #50

Open
3 tasks
ethe opened this issue Oct 5, 2024 · 0 comments
Open
3 tasks

Safety condition review #50

ethe opened this issue Oct 5, 2024 · 0 comments

Comments

@ethe
Copy link
Member

ethe commented Oct 5, 2024

fusio uses a set of unsafe block (especially in buffer read / write behaviors) to ensure that the performance is the same as natives, please check them at https://github.com/search?q=repo%3Atonbo-io%2Ffusio%20unsafe&type=code, I tried my best to keep them simple and small, however, it has not been widely reviewed by community, we should:

  • check all unsafe block, identify whether it should be an unsafe block
  • evaluate specific safety condition to each block
  • prevent undefined behavior
@ethe ethe added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2024
@ethe ethe removed documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant