Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement monoio-based HTTP client over hyper-tls #41

Open
ethe opened this issue Oct 3, 2024 · 1 comment
Open

Implement monoio-based HTTP client over hyper-tls #41

ethe opened this issue Oct 3, 2024 · 1 comment

Comments

@ethe
Copy link
Member

ethe commented Oct 3, 2024

In the current, there is no S3 suppor on the monoio runtime, implementing remotes::http::HttpClient for monoio https client over hypter-tls should be a possible way.

@ethe ethe added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2024
@a10y
Copy link
Contributor

a10y commented Oct 14, 2024

Capturing convo from Discord:

The monoio project does maintain an HTTP(S) client crate at https://github.com/monoio-rs/monoio-http

Running a minimal test to connect to the Umbra open satellite imagery S3 bucket, behind HTTPS, seems to succeed.

use monoio_http_client::Client;

#[monoio::main(enable_timer = true)]
async fn main() {
    let client = Client::default();
    let resp = client
        .get("https://umbra-open-data-catalog.s3.amazonaws.com/")
        .send()
        .await
        .expect("request fail");
    let http_resp = resp.bytes().await.unwrap();
    println!("{:?}", http_resp);
}
image

However, it's possible that there is a better pathway, e.g. writing custom executors over hyper-tls that maybe leads to more code sharing between the monoio and tokio-uring impls

@ethe ethe removed enhancement New feature or request good first issue Good for newcomers labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants