Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to emoji-regex v9 #61

Open
enzoferey opened this issue May 18, 2020 · 9 comments
Open

Update to emoji-regex v9 #61

enzoferey opened this issue May 18, 2020 · 9 comments

Comments

@enzoferey
Copy link
Collaborator

enzoferey commented May 18, 2020

@favna wrote a very informative explanation about emoji-regex status and its integration with the emoji image libraries we are using here.

We have now to agree on the direction we want the library to take with that regard. The options I could infer from his writing are:

  1. Don't update to Unicode 13.
  2. Update to Unicode 13 but keep EmojiOne on v2 (no Unicode 13 support).
  3. Update to Unicode 13 and place a notice about usage of EmojiOne for commercial usage.
  4. Update to Unicode 13 and drop EmojiOne.

Please tell me if I'm forgetting anything or you can think of another solution not mentioned above. Looking forward to your opinions.

@enzoferey enzoferey added the rfc label May 18, 2020
@favna
Copy link

favna commented May 18, 2020

Personally I'm mostly behind option 4, or otherwise option 2.

I think 1 is out of the question since unicode consortium seems to be going pretty fast (they do like what.. 1 release a year?) and that's going to cause this library to be be unuseable pretty fast all things considered.

As for option 3, while it is an appealing option, this package is already being used by 793 other open source projects on GitHub and god only knows how many closed sourced / hosted elsewhere projects. Between 2019-05-17 and 2020-05-17 it reached a total of 371,839 download from NPM and (with a weekly download reported at 12K per week!). In this massive amount there's bound to already be some commercial projects and since not everyone reads changelogs/readme's we'd be putting those users in risk by suddenly changing it to "no commercial use". The last thing we want is for JoyPixel to go after the commercial users and those users coming to this issue box about it.

Option 2 is also appealing, with the only drawback being that the code might get fragmented a bit, I haven't really delved into the code yet though so that might not be too bad. That's your call there really.

@tommoor
Copy link
Owner

tommoor commented May 18, 2020

It sounds like this update necessitates a breaking update as either Emojione is removed or it becomes JoyPixel. I do think there is value in keeping JoyPixel for OSS users and I don't blame them for having a commercial license. There is a relatively clean way to achieve this:

  1. Major version bump
  2. Rename emojione -> joypixel
  3. Add a prop, something like commercialLicenseAcknowledged – if it isn't set to true then the JoyPixel render component throws an error.

Thoughts?

@favna
Copy link

favna commented May 18, 2020

I actually really like the idea of using a prop that way!

@enzoferey
Copy link
Collaborator Author

Pretty cool idea for the prop indeed 👌I think we all agree that option 3 is the best, let's do it then !

@favna please feel free to jump into the code if you have any interest about it being shipped fast. I don't use the library in production at the moment (and probably never with JoyPixel), so I don't have a big motivator for implementing this in the upcoming weeks.

@enzoferey enzoferey added help wanted and removed rfc labels May 18, 2020
@favna
Copy link

favna commented May 18, 2020

I'll see what I can do when I got time. First got quite a few other things on the project I'm using this lib for to iron out. Can't make any promises on when I'll do the dive though (but it will be in the coming weeks).

@Geczy
Copy link

Geczy commented Jul 28, 2022

2 years later, any update?

@favna
Copy link

favna commented Jul 28, 2022

I never spent any time on this anymore. I still use the library but I haven't had a need to update it so I never really got around it. I'm too busy with other projects.

@Geczy
Copy link

Geczy commented Jul 28, 2022

no problem, i updated it on my own repo to support new emojis https://github.com/geczy/react-emoji-render/

@enzoferey
Copy link
Collaborator Author

enzoferey commented Aug 4, 2022

Hey @Geczy , I only see dependencies bumps and formatting changes on your fork, but please feel free to work in this issue if you like 😁 (and even better, open a PR so others can benefit from it !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants