-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to emoji-regex v9 #61
Comments
Personally I'm mostly behind option 4, or otherwise option 2. I think 1 is out of the question since unicode consortium seems to be going pretty fast (they do like what.. 1 release a year?) and that's going to cause this library to be be unuseable pretty fast all things considered. As for option 3, while it is an appealing option, this package is already being used by 793 other open source projects on GitHub and god only knows how many closed sourced / hosted elsewhere projects. Between 2019-05-17 and 2020-05-17 it reached a total of 371,839 download from NPM and (with a weekly download reported at 12K per week!). In this massive amount there's bound to already be some commercial projects and since not everyone reads changelogs/readme's we'd be putting those users in risk by suddenly changing it to "no commercial use". The last thing we want is for JoyPixel to go after the commercial users and those users coming to this issue box about it. Option 2 is also appealing, with the only drawback being that the code might get fragmented a bit, I haven't really delved into the code yet though so that might not be too bad. That's your call there really. |
It sounds like this update necessitates a breaking update as either Emojione is removed or it becomes JoyPixel. I do think there is value in keeping JoyPixel for OSS users and I don't blame them for having a commercial license. There is a relatively clean way to achieve this:
Thoughts? |
I actually really like the idea of using a prop that way! |
Pretty cool idea for the prop indeed 👌I think we all agree that option 3 is the best, let's do it then ! @favna please feel free to jump into the code if you have any interest about it being shipped fast. I don't use the library in production at the moment (and probably never with JoyPixel), so I don't have a big motivator for implementing this in the upcoming weeks. |
I'll see what I can do when I got time. First got quite a few other things on the project I'm using this lib for to iron out. Can't make any promises on when I'll do the dive though (but it will be in the coming weeks). |
2 years later, any update? |
I never spent any time on this anymore. I still use the library but I haven't had a need to update it so I never really got around it. I'm too busy with other projects. |
no problem, i updated it on my own repo to support new emojis https://github.com/geczy/react-emoji-render/ |
Hey @Geczy , I only see dependencies bumps and formatting changes on your fork, but please feel free to work in this issue if you like 😁 (and even better, open a PR so others can benefit from it !) |
@favna wrote a very informative explanation about
emoji-regex
status and its integration with the emoji image libraries we are using here.We have now to agree on the direction we want the library to take with that regard. The options I could infer from his writing are:
Please tell me if I'm forgetting anything or you can think of another solution not mentioned above. Looking forward to your opinions.
The text was updated successfully, but these errors were encountered: