From a275eb931252392d3bae64221ea33ad9e4de6686 Mon Sep 17 00:00:00 2001 From: CoralPink <03_stylist_triages@icloud.com> Date: Mon, 27 May 2024 22:16:53 +0900 Subject: [PATCH 1/2] Hide extra markers displayed in `Safari`. --- compile_assets/scss/admonition.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/compile_assets/scss/admonition.scss b/compile_assets/scss/admonition.scss index 4d4075f..babe7da 100644 --- a/compile_assets/scss/admonition.scss +++ b/compile_assets/scss/admonition.scss @@ -198,6 +198,10 @@ a.admonition-anchor-link { &:hover a.admonition-anchor-link { display: initial; } + + &::-webkit-details-marker { + display: none; + } } summary.admonition-title { From 54d27fcd5ed5f1a2bfd04f44d4fa2ff1edb2a43f Mon Sep 17 00:00:00 2001 From: Tom Milligan Date: Fri, 16 Aug 2024 09:23:19 +0100 Subject: [PATCH 2/2] [review] move webkit fix --- compile_assets/scss/admonition.scss | 10 ++++++---- integration/book.toml | 2 +- integration/expected/book.toml | 2 +- src/bin/assets/VERSION | 2 +- src/bin/assets/mdbook-admonish.css | 3 +++ 5 files changed, 12 insertions(+), 7 deletions(-) diff --git a/compile_assets/scss/admonition.scss b/compile_assets/scss/admonition.scss index babe7da..4a7e961 100644 --- a/compile_assets/scss/admonition.scss +++ b/compile_assets/scss/admonition.scss @@ -198,10 +198,6 @@ a.admonition-anchor-link { &:hover a.admonition-anchor-link { display: initial; } - - &::-webkit-details-marker { - display: none; - } } summary.admonition-title { @@ -226,6 +222,12 @@ summary.admonition-title { details[open].admonition > &::after { transform: rotate(90deg); } + + // Hide details marker for Safari that loves to show it anyway + // ref: https://github.com/tommilligan/mdbook-admonish/pull/185 + &::-webkit-details-marker { + display: none; + } } :root { diff --git a/integration/book.toml b/integration/book.toml index 1aae74e..cdcd158 100644 --- a/integration/book.toml +++ b/integration/book.toml @@ -9,7 +9,7 @@ title = "mdbook-admonish-integration" [preprocessor.admonish] command = "mdbook-admonish" -assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install` +assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install` after = ["links"] [[preprocessor.admonish.custom]] diff --git a/integration/expected/book.toml b/integration/expected/book.toml index 1aae74e..cdcd158 100644 --- a/integration/expected/book.toml +++ b/integration/expected/book.toml @@ -9,7 +9,7 @@ title = "mdbook-admonish-integration" [preprocessor.admonish] command = "mdbook-admonish" -assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install` +assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install` after = ["links"] [[preprocessor.admonish.custom]] diff --git a/src/bin/assets/VERSION b/src/bin/assets/VERSION index b502146..75a22a2 100644 --- a/src/bin/assets/VERSION +++ b/src/bin/assets/VERSION @@ -1 +1 @@ -3.0.2 +3.0.3 diff --git a/src/bin/assets/mdbook-admonish.css b/src/bin/assets/mdbook-admonish.css index 45aeff0..88dd2b1 100644 --- a/src/bin/assets/mdbook-admonish.css +++ b/src/bin/assets/mdbook-admonish.css @@ -106,6 +106,9 @@ details.admonition > summary.admonition-title::after { details[open].admonition > summary.admonition-title::after { transform: rotate(90deg); } +summary.admonition-title::-webkit-details-marker { + display: none; +} :root { --md-details-icon: url("data:image/svg+xml;charset=utf-8,");