Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of Disk Lable like "D:\" in windows #36

Open
ericsunplus opened this issue Aug 4, 2023 · 6 comments
Open

Wrong handling of Disk Lable like "D:\" in windows #36

ericsunplus opened this issue Aug 4, 2023 · 6 comments

Comments

@ericsunplus
Copy link

Hi there,

Thanks for the plugin, it works perfectly in Ubuntu. However when I goes into windows, the file path starts with Disk Label like "D:....". It seems fubitive will recognize D: as a git revision. Results in

The path "..." does not exist at revision "D"
@mark2185
Copy link
Collaborator

mark2185 commented Aug 4, 2023

Is this a problem only with vim-fubitive, or with vim-fugitive?

@ericsunplus
Copy link
Author

Hi @mark2185 , I tried with github repo with vim-rhubarb. No such issue is there.

@mark2185
Copy link
Collaborator

mark2185 commented Aug 4, 2023

Alright, could you please give me the steps to try and reproduce it?

@ericsunplus
Copy link
Author

Hi @mark2185 , I don't find a public bitbucket repo. I am working in a company bitbucket repo. Open any file under it and use GBrowse, it will show a page indicating

The path "..." does not exist at revision "D"

The URL is ending with ?at=D, removing it can show the correct file in repo

@mark2185
Copy link
Collaborator

mark2185 commented Aug 7, 2023

I guess the PR #34 could fix this behaviour.

Could you please try it out to see if it helps?

@ericsunplus
Copy link
Author

ericsunplus commented Aug 7, 2023

I am not sure if I doing it right. I cherry pick 7321a38 but it don't help. the ?at=D changes to ?until=D, which is still not solving the "D:\" translate from a disk label to a git revision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants