Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor feature suggestions #136

Open
imdfl opened this issue Mar 27, 2022 · 4 comments
Open

Minor feature suggestions #136

imdfl opened this issue Mar 27, 2022 · 4 comments
Assignees

Comments

@imdfl
Copy link
Collaborator

imdfl commented Mar 27, 2022

  • Allow locale selection in the popup browser. Reading the English term may be useful while staying in the containing page's locale. We can easily include the available locales in the parsed page data.
  • Make the popover draggable. This will enforce a minimal titlebar which is a good solution for the closebox, currently overlapping the scrollbar, when present.
@tomerlichtash
Copy link
Owner

  • Locale Selection in Popover – Good idea. We need to see how multiple locales can live in one space.
  • Draggable Popover – I think it's a specific feature that might be obsolete with a fixed Popover (like in the Genius example) that might serve us better.

@tomerlichtash
Copy link
Owner

Locale Selection in Popver is previously mentioned here: #104

@imdfl
Copy link
Collaborator Author

imdfl commented Apr 7, 2022

Well, as long as we have a floating popover, I'd expect it to be draggable. It's a content site, you should be able to move a floating window to expose some text (and still see the floater).

@tomerlichtash
Copy link
Owner

I'd like to ask another question - What value does the user get from draggable ability?
I submit (!) that the value is:

  1. Control over the visibility of the actual text
  2. Control over parallel reading ability (codex/popover)

I believe we can give the user these controls by creating a fixed (or "docked") view of the popover.

Other problems arise from this solution (if drag or docked or other) - which are in the domain of the highlighted word vs the scope of the popover.

I believe dragging ability would enhance this detachment, and create more confusion, especially if one navigates inside a popover.

On another note (no pun intended): The current popover is an MVP version; it currently lacks a mobile solution (next in my development queue IMHO) and this is a good opportunity to rethink the whole thing, with what we've learned so far:

Problems to discuss in that scope are:

  1. Toolbar deceleration
  2. Inline/Docked/Mobile views
  3. Draggable options (to Dock? anywhere?)
  4. Anchored Trigger relations (problem already exists in popover navigation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants