Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change root note handling #22

Open
tomcontileslie opened this issue Nov 28, 2020 · 0 comments
Open

Change root note handling #22

tomcontileslie opened this issue Nov 28, 2020 · 0 comments

Comments

@tomcontileslie
Copy link
Owner

Currently the first element of the list of interpreted notes is considered the root, and the following notes are considered the important ones. I suggest we make the interpretation function output a tuple (out, root) where root is the bass note and out contains all the notes, still most to least important. It might be time to retire the rank_important function, in the sense that some important notes (root, fifth) are best places on the low strings while the more musical, but also important, ones (sevenths, ninths, etc) are better on high strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant