Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has waker check doesn't work with try_cloned Registries #1698

Closed
Thomasdezeeuw opened this issue Jul 27, 2023 · 1 comment · Fixed by #1706
Closed

Has waker check doesn't work with try_cloned Registries #1698

Thomasdezeeuw opened this issue Jul 27, 2023 · 1 comment · Fixed by #1706

Comments

@Thomasdezeeuw
Copy link
Collaborator

Initially discovered here: #1687 (comment).

Currently the AtomicBools are on the Selector and cloned in a call to Selector::try_clone, but are not synchronised any more. So you can try_clone the Registry and register a second Waker.
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jul 27, 2023
Merged
@Thomasdezeeuw
Copy link
Collaborator Author

I'm going to address this after #1687 is merged as that also has the same issue. I think the easiest solution is to use an Arc<AtomicBool> to ensure the state is shared. Since it's debug only I don't think the overhead of the Arc matters.

@Thomasdezeeuw Thomasdezeeuw mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move has_waker boolean to Registry Thomasdezeeuw/mio
1 participant
@Thomasdezeeuw