-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make serve
generic over the listener and IO types
#2941
Conversation
53c870c
to
72871dc
Compare
72871dc
to
26a37a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
The underlying theme of the comments seems to be what do we want this to eventually look like and whether to move some functionality in serve
into the Listener
instances so I guess that's the main thing I'd want your opinions on.
26a37a4
to
e8644d8
Compare
@mladedav I think I've addressed all of your concern with the three new commits I've added. Let me know what you think! |
a5f7c1d
to
c6df5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great. Thanks for finishing it.
Supersedes #2479.